Don’t allow other users to connect by default#28
Merged
Conversation
This is the most secure default configuration, and prevents local privilege escalation vulnerabilities. On Unix, permissions are set to 0o600, while on Windows, the DACL of the process’s token is used.
Contributor
|
Thanks @demimarie-parity I am not sure this should be default. Have you researched how other libraries are organised and what users expect to be default (deny or allow all)? |
Contributor
Author
|
@NikVolf Personally, I expect the default to be to deny access. Furthermore, overly strict permissions will be caught during testing, while overly loose permissions will not unless explicitly checked for. |
Contributor
Author
|
@NikVolf I looked at permissions and found:
|
|
Could you release a new version including these changes on crates.io? It will allow us to get rid of some workarounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most secure default configuration, and prevents local
privilege escalation vulnerabilities. On Unix, permissions are set to
0o600, while on Windows, the DACL of the process’s token is used.